Add cell type filter to heightmap editor brush panel by Copilot · Pull Request #1381 · Azgaar/Fantasy-Map-Generator

Copilot · 2026-04-22T09:05:13Z

Description

Adds a cellTypeFilter select input to the heightmap editor brush panel, allowing users to restrict brush operations to all cells, only land cells, or only water cells. This prevents accidental coastline changes or new landmass creation while editing ocean depths, and vice versa.

src/index.html

Replaced the two separate changeOnlyLand and changeOnlyOcean checkboxes with a single <select id="cellTypeFilter"> dropdown offering three options: all cells (default), only land cells, and only water cells

public/modules/ui/heightmap-editor.js

Mode switching — sets cellTypeFilter.value on mode change: keep mode selects "land", erase/risk modes reset to "all"
updateHeightmap() — safety rollback reverts cells that crossed the h=20 land/water boundary based on the active filter
dragBrush() — pre-filters brush selection to land (h >= 20) or water (h < 20) cells depending on the selected filter
placeLinearFeature() — skips land or water cells based on the active filter
changeHeightForSelection() — lim bounds adjusted per filter (min=20 for land-only, max=19 for water-only); brushRaise skips the ocean-to-land jump in water-only mode; brushSmooth neighbor filter respects the active filter
rescale() — skips out-of-filter cells and clamps output to the appropriate range
startFromScratch() — blocked when any non-"all" filter is active
cellTypeFilterChange() — new handler that prevents selecting "land" filter in keep edit mode

netlify · 2026-04-22T09:05:35Z

✅ Deploy Preview for afmg ready!

Name	Link
🔨 Latest commit	`1edb1e2`
🔍 Latest deploy log	https://app.netlify.com/projects/afmg/deploys/69e89d26848a9e00088374ba
😎 Deploy Preview	https://deploy-preview-1381--afmg.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Agent-Logs-Url: https://github.com/Azgaar/Fantasy-Map-Generator/sessions/4011258c-2dd9-45c2-bec6-bd390cb8ca73 Co-authored-by: Azgaar <26469650+Azgaar@users.noreply.github.com>

Azgaar · 2026-04-22T09:22:34Z

@copilot, replace two checkboxes with a select input with 'check all cells', 'check only land cells' and 'check only water cells' options.

Azgaar

replace two checkboxes with a select input with 'check all cells', 'check only land cells' and 'check only water cells' options.

Agent-Logs-Url: https://github.com/Azgaar/Fantasy-Map-Generator/sessions/e456d324-554b-4ee5-98ae-3c28da95ecca Co-authored-by: Azgaar <26469650+Azgaar@users.noreply.github.com>

Copilot · 2026-04-22T10:04:31Z

@copilot, replace two checkboxes with a select input with 'check all cells', 'check only land cells' and 'check only water cells' options.

Done in 1edb1e2. The two checkboxes are replaced with a single cellTypeFilter select in the brush panel with three options: all cells, only land cells, and only water cells. All brush operations, rescaler, and startFromScratch are updated to read from this select. The 'Keep' edit mode continues to auto-select "only land cells" and blocks switching to anything else via the change handler.

Copilot

Pull request overview

This PR updates the heightmap editor brush UI to use a single cellTypeFilter dropdown, letting users restrict edits to all cells, land-only, or water-only, to reduce accidental coastline changes during height editing.

Changes:

Replaces prior cell-type restriction checkboxes with a single cellTypeFilter <select> in the brush panel UI
Updates heightmap brush/line editing logic to honor the selected cell-type filter (including some safety rollback and rescale behavior)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/index.html	Replaces the previous checkbox UI with a `cellTypeFilter` dropdown
public/modules/ui/heightmap-editor.js	Wires the new filter into brush/line operations, rescale, and mode switching

Copilot · 2026-04-22T10:12:41Z

+      if (cellTypeFilter.value === "land" && heightmapEditMode.innerHTML === "keep") {
+        tip("You cannot change the coastline in 'Keep' edit mode", false, "error");
+        cellTypeFilter.value = "all";


cellTypeFilterChange currently blocks selecting the "land" filter in "keep" mode and resets to "all". In "keep" mode the UI copy says the coastline cannot change, which requires forcing a land-only constraint (matching enterHeightmapEditMode setting cellTypeFilter.value = "land"). Consider preventing changes away from "land" while in keep mode (e.g., revert to "land" / disable the select) rather than rejecting the land option.

Suggested change

if (cellTypeFilter.value === "land" && heightmapEditMode.innerHTML === "keep") {

tip("You cannot change the coastline in 'Keep' edit mode", false, "error");

cellTypeFilter.value = "all";

if (heightmapEditMode.innerHTML === "keep" && cellTypeFilter.value !== "land") {

tip("You cannot change the coastline in 'Keep' edit mode", false, "error");

cellTypeFilter.value = "land";

Copilot · 2026-04-22T10:12:41Z

      let selection = [];
      for (let i = 0; i < heights.length; i++) {
        if (changedHeights[i] === heights[i]) continue;
-        if (changeOnlyLand.checked && heights[i] < 20) continue;
+        if (cellTypeFilter.value === "land" && heights[i] < 20) continue;
+        if (cellTypeFilter.value === "water" && heights[i] >= 20) continue;
        heights[i] = changedHeights[i];
        selection.push(i);


In placeLinearFeature, the cell-type filter checks heights[i] (the pre-operation height) to decide whether to apply changedHeights[i]. This allows coastline changes to slip through (e.g., a land cell can be lowered below 20 in land-only mode, or a water cell raised above 19 in water-only mode), and this path doesn't call updateHeightmap() so the rollback logic won't correct it. Filter/clip based on the resulting height (changedHeights[i]) and/or reuse the same limiting logic used by brush editing, or call updateHeightmap() after applying the changes.

Initial plan

96a1033

Copilot AI assigned Copilot and Azgaar Apr 22, 2026

Copilot AI requested review from Copilot and removed request for Copilot April 22, 2026 09:05

Copilot started work on behalf of Azgaar April 22, 2026 09:05 View session

Copilot AI linked an issue Apr 22, 2026 that may be closed by this pull request

Change Ocean Cells Only #1379

Closed

Add 'Change Only Ocean Cells' checkbox to heightmap editor

62da4f8

Agent-Logs-Url: https://github.com/Azgaar/Fantasy-Map-Generator/sessions/4011258c-2dd9-45c2-bec6-bd390cb8ca73 Co-authored-by: Azgaar <26469650+Azgaar@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot April 22, 2026 09:17

Copilot AI changed the title ~~[WIP] Add checkbox to change only ocean cells in heightmap editor~~ Add "Change Only Ocean Cells" checkbox to heightmap editor Apr 22, 2026

Copilot finished work on behalf of Azgaar April 22, 2026 09:19

Copilot AI requested a review from Azgaar April 22, 2026 09:19

Azgaar requested changes Apr 22, 2026

View reviewed changes

Copilot started work on behalf of Azgaar April 22, 2026 09:57 View session

Replace land/ocean checkboxes with cellTypeFilter select dropdown

1edb1e2

Agent-Logs-Url: https://github.com/Azgaar/Fantasy-Map-Generator/sessions/e456d324-554b-4ee5-98ae-3c28da95ecca Co-authored-by: Azgaar <26469650+Azgaar@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot April 22, 2026 10:04

Copilot AI changed the title ~~Add "Change Only Ocean Cells" checkbox to heightmap editor~~ Add cell type filter to heightmap editor brush panel Apr 22, 2026

Copilot finished work on behalf of Azgaar April 22, 2026 10:06

Copilot AI requested a review from Azgaar April 22, 2026 10:06

Azgaar marked this pull request as ready for review April 22, 2026 10:08

Copilot AI review requested due to automatic review settings April 22, 2026 10:08

Azgaar merged commit eceb8c5 into master Apr 22, 2026
4 checks passed

Azgaar deleted the copilot/add-ocean-cells-checkbox branch April 22, 2026 10:08

Copilot AI reviewed Apr 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add cell type filter to heightmap editor brush panel#1381

Add cell type filter to heightmap editor brush panel#1381
Azgaar merged 3 commits intomasterfrom
copilot/add-ocean-cells-checkbox

Copilot AI commented Apr 22, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Apr 22, 2026 •

edited

Loading

Uh oh!

Azgaar commented Apr 22, 2026

Uh oh!

Azgaar left a comment

Uh oh!

Copilot AI commented Apr 22, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Copilot AI Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Copilot AI commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

netlify Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for afmg ready!

Uh oh!

Azgaar commented Apr 22, 2026

Uh oh!

Azgaar left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Apr 22, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 22, 2026 •

edited

Loading

netlify Bot commented Apr 22, 2026 •

edited

Loading